This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
EVG-20086 Add task blocked event copy #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimchelly
approved these changes
Sep 5, 2023
| @@ -17,6 +17,9 @@ export const TaskEventLogLine: React.FC<TaskEventLogEntry> = ({ | |||
| const containerOrHostCopy = podId ? "container" : "host"; | |||
| let message: JSX.Element; | |||
| switch (eventType) { | |||
| case TaskEventType.TaskBlocked: | |||
| message = <>This task is blocked.</>; | |||
There was a problem hiding this comment.
nit: the tense of this one is a little different from the other ones already here, should it say something like Task is blocked or Task blocked for consistency with the others?
sophstad
approved these changes
Sep 5, 2023
Passing run #12474 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVG-20086
Description
Added a new event for TASK_BLOCKED. There isn't any additional info in the event that can be used for the copy.
Screenshots